14853 - Create Task When New Product Add by GOVM/GOVN#3584
Merged
Jxio merged 21 commits intobcgov:mainfrom Jan 28, 2026
Merged
Conversation
Collaborator
Author
|
/gcbrun |
seeker25
reviewed
Jan 22, 2026
auth-web/src/components/auth/staff/account-management/StaffPendingAccountsTable.vue
Outdated
Show resolved
Hide resolved
Collaborator
|
Temporary Url for review: https://bcregistry-account-dev--pr-3584-p8xzrbry.web.app |
Collaborator
|
Temporary Url for review: https://bcregistry-account-dev--pr-test-3584-gwrvqtni.web.app |
seeker25
reviewed
Jan 22, 2026
seeker25
reviewed
Jan 22, 2026
seeker25
reviewed
Jan 22, 2026
seeker25
reviewed
Jan 22, 2026
auth-web/src/components/auth/staff/account-management/StaffPendingAccountsTable.vue
Show resolved
Hide resolved
seeker25
reviewed
Jan 22, 2026
seeker25
reviewed
Jan 22, 2026
seeker25
reviewed
Jan 22, 2026
seeker25
reviewed
Jan 27, 2026
...es/account-mailer/src/account_mailer/email_templates/prod_package_approved_notification.html
Outdated
Show resolved
Hide resolved
seeker25
reviewed
Jan 27, 2026
...es/account-mailer/src/account_mailer/email_templates/prod_package_rejected_notification.html
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
I think this one not relate to current code change: |
seeker25
reviewed
Jan 28, 2026
seeker25
reviewed
Jan 28, 2026
seeker25
reviewed
Jan 28, 2026
Comment on lines
+27
to
+38
| try: | ||
| token = RestService.get_service_account_token() | ||
| response = RestService.get(endpoint=f"{pay_url}/accounts/{org.id}/fees", token=token, retry_on_failure=True) | ||
|
|
||
| if response and response.status_code == 200: | ||
| response_data = response.json() | ||
| account_fees = response_data.get("accountFees", []) | ||
|
|
||
| for fee in account_fees: | ||
| product_code = fee.get("product") | ||
| if product_code: | ||
| account_fees_dict[product_code] = True |
Collaborator
There was a problem hiding this comment.
I don't think this logic is unit tested? should it be?
seeker25
reviewed
Jan 28, 2026
seeker25
approved these changes
Jan 28, 2026
seeker25
reviewed
Jan 28, 2026
Collaborator
|
Looks good to me, nice job |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#14853
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).